Fixes the FontSizePicker Custom option #18842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit prevent the "Custom" option still showing up in the font sizes drop down when a WordPress theme uses the `add_theme_support( 'disable-custom-font-sizes' )` feature.
JeanDavidDaviet
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
talldan and
youknowriad
as code owners
ZebulanStanphill
requested changes
Nov 30, 2019
The slider didn't update the select options. In the new `onSliderChangeValue` function, we set the new fontSize state with the props function `onChange` and we also set the selection option given the new font size.
This reverts commit 73f952f. I don't know why Travis doesn't accept this commit.
JeanDavidDaviet
commented
Dec 2, 2019
There was a problem hiding this comment.
I don't understand why this change makes Travis build fail. @ZebulanStanphill ?
They are necessary to update the custom select when the fontsize slider is used.
|
@JeanDavidDaviet The automated tests haven't been working quite right lately, so the failure may be unrelated. Try recommitting the change. |
This reverts commit aa62643.
|
@ZebulanStanphill Thanks, that was it ! |
ZebulanStanphill
approved these changes
Dec 3, 2019
ZebulanStanphill
added
[Feature] Themes
|
It would be good to add tests for this. |
@epiqueras I won't be home for december, but I sure would like to see the test suite for this feature implemented (or modified) as I'm not a good test writer. |
youknowriad
removed
the
Backport to WP Beta/RC
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18716
This commit prevent the "Custom" option still showing up in the font sizes drop down when a WordPress theme uses the
add_theme_support( 'disable-custom-font-sizes' )feature.Description
There was no check on the
disableCustomFontSizesvariable. The custom object{ slug: 'custom', name: __( 'Custom' ) }was then always added even when not wanted.How has this been tested?
Tested with Storybook and npm test
Types of changes
Bug Fix
Checklist: